Bump minimum JTH version in JenkinsTestHarnessHook2

[basil]

Test jenkinsci/plugin-compat-tester#769 in jenkinsci/bom in advance of its eventual adoption in CloudBees CI.

Testing done

This is it

[jglick]

@MarkEWaite et al., any recollection of why this or jenkinsci/plugin-compat-tester#769 would be necessary? The bump is to pick up jenkinsci/jenkins-test-harness#941 but most plugins have long since picked up a parent with that version anyway. I am not sure what the “eventual adoption in CloudBees CI” referred to; there is no link to anything in CloudBees and I am not aware of any special handling in CloudBees CI related to this. I think both PRs can be closed now?

[MarkEWaite]

@MarkEWaite et al., any recollection of why this or jenkinsci/plugin-compat-tester#769 would be necessary? The bump is to pick up jenkinsci/jenkins-test-harness#941 but most plugins have long since picked up a parent with that version anyway

I don't think this pull request is needed any longer, since the master branch already provides a newer version of the dependency and the minimum Jenkins version is now past the 2.492.3 that is mentioned.

I'm not as clear on the other pull request:

• https://github.com/jenkinsci/plugin-compat-tester#769

Since the pull request comment says that it is updating the test harness for older lines, it seems the version number could be made even larger to match with the current minimum Jenkins version in the plugin BOM.

Maybe @jtnord knows more?

[jtnord]

Since the pull request comment says that it is updating the test harness for older lines, it seems the version number could be made even larger to match with the current minimum Jenkins version in the plugin BOM.

IIRC it was to ensure we got jakartaee servlet dependencies otherwise we got javaee servlet with a Jenkins that needed jakarta things which then broken. But there was some issues because other parts of the jenkins-test-harness where not binary compatible so it worked to upgrade form some bound but not all lower bounds.

Shouldn't be needed anymore and given its not been done and things have not broken I would also surmise that the upstream hook is be redundant and can be removed (it can be brought back to life if needed in the future).

[jglick]

the upstream hook is […] redundant and can be removed

Well, note that jenkinsci/plugin-compat-tester#769 merely changes the version of the PCT hook; the current minimum picks up jenkinsci/jenkins-test-harness#907, something to do with web.xml. The hook would be inactive on a well-maintained plugin; not sure if it is currently needed by bom (or CloudBees CI PCT runs).