Skip to content

Conversation

@schu96
Copy link
Collaborator

@schu96 schu96 commented Jan 3, 2026

Makes CSS property assignments for translation text layers before class name showingTranslation is added

Includes a small CSS change that hides the BRtranslateLayer elements during the page flip animation

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.43%. Comparing base (fefbb8a) to head (71fdf0f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   69.43%   69.43%           
=======================================
  Files          62       62           
  Lines        5330     5330           
  Branches     1156     1156           
=======================================
  Hits         3701     3701           
  Misses       1594     1594           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice! It's working better on the initial load when I first click "translate", but as I flip around, I still get the odd large translation layer on chrome; it only sizes correctly after the text loads in 🤔

Copy link
Contributor

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well colour me surprised, that's not at all what I expected to fix this :P But it's working like a charm now! 🥳

@cdrini cdrini merged commit 7ae6252 into internetarchive:master Jan 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants