test: replaced node-fetch with native fetch in test setup

[aryamohanan]

Migrate test setup files from node-fetch-v2 to the native fetch API available in Node.js 18+. This change removes the dependency on node-fetch-v2 in the test code and uses the built-in fetch implementation instead.

Note:
This update replaces all usages of node-fetch-v2 in the test setup.

Background:

• PR introducing node-fetch-v2: https://github.com/instana/nodejs/pull/1160/files
• Reference: https://jsw.ibm.com/browse/INSTA-15850

[kirrg001]

https://jsw.ibm.com/browse/INSTA-15850

[aryamohanan]

Native fetch and node-fetch represent the same failure; they are just surfaced differently.

Native fetch:

• Throws a TypeError: fetch failed
• The real cause is nested under error.cause

node-fetch:

• Throws a FetchError
• The connection error is exposed directly

[kirrg001]

Hm but where is the ECONNREFUSED information?

[aryamohanan]

Yea, its there

TypeError: fetch failed
at node:internal/deps/undici/undici:14900:13
at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
[cause]: Error: connect ECONNREFUSED 127.0.0.1:65212
at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1637:16)
at TCPConnectWrap.callbackTrampoline (node:internal/async_hooks:130:17) {
errno: -61,
code: 'ECONNREFUSED',
syscall: 'connect',
address: '127.0.0.1',
port: 65212
}
} console.error - should be traced

[kirrg001]

Then I guess there is a bug in the instrumentation?
See also https://github.com/instana/nodejs/pull/2022/files#r2675869932

[abhilash-sivan]

I believe this also needs to be removed!

nodejs/packages/collector/test/metrics/app/package.json

Line 21 in f1c571f

"node-fetch": "^2.6.0"

[aryamohanan]

I believe this also needs to be removed!

nodejs/packages/collector/test/metrics/app/package.json

Line 21 in f1c571f

"node-fetch": "^2.6.0"

@abhilash-sivan IMO, this is not part of the test setup code. It is a minimal test application (metrics-test-app) that exists solely to be test the metrics collection.

The purpose of the test is to verify that when this application runs with node-fetch as a dependency, the metrics system reports it correctly. Therefore, this dependency is not related to test setup and does not need to be replaced or removed the test explicitly requires an external dependency to validate the behavior.

[abhilash-sivan]

LGTM

[kirrg001]

See comments 👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud