Skip to content

Conversation

@hygao1024
Copy link
Contributor

Summary

Exclude the enterprise-only watchdog feature from mypy type checking to avoid unnecessary analysis in the community edition.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring

Related Issue

Changes

  • Excluded the enterprise watchdog module from mypy type checks
  • Clarified separation between community and enterprise-only features

Testing

  • Existing tests pass
  • New tests added (if applicable)
  • Manual testing completed

Screenshots (if applicable)

Checklist

  • Code follows project coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Breaking changes documented

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds a type: ignore to handle an optional enterprise dependency during static analysis. My review includes one high-severity comment regarding the exception handling for this optional import. The current implementation uses a broad except Exception, which can hide bugs in the enterprise feature. I've recommended narrowing this to except ImportError for more robust error handling.

@hygao1024 hygao1024 merged commit 35f4998 into iflytek:main Feb 2, 2026
20 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant