Skip to content

Conversation

@zijian2
Copy link
Contributor

@zijian2 zijian2 commented Jan 30, 2026

…t-side span hook

  • Add log initialization before starting uvicorn service
  • Fix client-side span hook to avoid affecting main request chain
  • Temporary fixes included in refactoring process

Summary

initialize logging before uvicorn service and fix client-side span hook

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring

Related Issue

Changes

  • initialize logging before uvicorn service and fix client-side span hook

Testing

  • Existing tests pass
  • New tests added (if applicable)
  • Manual testing completed

Screenshots (if applicable)

Checklist

  • Code follows project coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Breaking changes documented

…t-side span hook

- Add log initialization before starting uvicorn service
- Fix client-side span hook to avoid affecting main request chain
- Temporary fixes included in refactoring process

Signed-off-by: zijian2 <[email protected]>
@Alex-Smith-1234 Alex-Smith-1234 merged commit 0f76add into iflytek:main Jan 30, 2026
29 of 30 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a series of valuable improvements across the aitools plugin. Key changes include initializing logging before the Uvicorn service starts for better startup diagnostics, and making client-side span hooks more robust by adding exception handling to prevent crashes in the main request chain. The PR also contains numerous code quality enhancements, such as adding timeouts to network requests, fixing incorrect os.getenv usage, adopting better exception chaining with from, and refactoring code for better readability and adherence to Python best practices. Overall, these changes significantly improve the stability, correctness, and maintainability of the codebase. The code quality is high, and I have no major concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants