Refactor Vizio integration to use DataUpdateCoordinator #162188
+351
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
raman325
force-pushed
the
vizio-device-coordinator
branch
from
acf581b to
3d60cf6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Vizio integration to use the standard DataUpdateCoordinator pattern instead of custom polling logic, improving code maintainability and consistency with Home Assistant best practices.
Changes:
- Introduced
VizioDeviceCoordinatorto centralize device state polling and data management - Refactored
VizioDeviceentity to extendCoordinatorEntityand consume coordinator data - Migrated from
hass.datastorage to theruntime_datapattern with proper type hints viaVizioConfigEntrytype alias - Fixed test assertions to match actual behavior (volume calculations, sound mode handling, power state types)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/vizio/__init__.py |
Creates device and coordinators during setup, uses runtime_data pattern for storing integration data |
homeassistant/components/vizio/coordinator.py |
Adds new VizioDeviceCoordinator class to handle device state polling, device registry updates, and availability tracking |
homeassistant/components/vizio/media_player.py |
Refactored entity to extend CoordinatorEntity, removed custom polling logic, processes coordinator data via callbacks |
tests/components/vizio/conftest.py |
Updated mock paths from media_player to coordinator and init, added mock for get_current_app_config |
tests/components/vizio/test_media_player.py |
Fixed test assertions (volume calculations, power state types), updated mock paths, corrected logging expectations |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
epenet
requested changes
Feb 4, 2026
Contributor
epenet
left a comment
epenet
left a comment
There was a problem hiding this comment.
Please ensure that you use the new VizioConfigEntry in the coordinator typing
Co-authored-by: epenet <[email protected]>
Co-authored-by: epenet <[email protected]>
epenet
reviewed
Feb 4, 2026
Addresses PR review feedback: - Move type definitions to coordinator.py to keep typing consistent - Update coordinator classes to use VizioConfigEntry type - Import VizioConfigEntry from coordinator (canonical location) Co-Authored-By: Claude Opus 4.5 <[email protected]>
raman325
force-pushed
the
vizio-device-coordinator
branch
from
04dd42d to
5f558f2
Compare
Update async_get_options_flow to use VizioConfigEntry type. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move VizioConfigEntry and VizioRuntimeData to top of file for better readability. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Move input list transformation to media_player platform. API manipulation and transformation logic should live in the platforms that consume them. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The None value is handled appropriately downstream. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Transform InputItem objects to strings in media_player.py since API manipulation logic belongs in the consuming platform. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Migrate the Vizio integration to use a proper DataUpdateCoordinator for device state polling instead of custom polling logic.
This PR is the prequel to a future new PR to add a remote entity platform so that users can send remote keys to their device. Since remotes also require the is_on state, it made sense to move everything to a coordinator first.
This change:
VizioDeviceCoordinatorto handle device state updatesruntime_datapattern instead ofhass.datafor storing device instanceVizioDeviceto extendCoordinatorEntityVizioConfigEntrytype alias for proper typingType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: