Skip to content

Conversation

@TerrorJack
Copy link
Contributor

  • simdutf: update to 8.0.0 and use upstream c api
  • ci: add simdutf-is-genuine ci job to check if vendored simdutf is genuine

This patch updates vendored simdutf to 8.0.0:
https://github.com/simdutf/simdutf/releases/tag/v8.0.0, and makes use
of simdutf's own C API.
This commit adds a simdutf-is-genuine CI job to check if vendored
simdutf is identical to the files in the singleheader.zip upstream
release archive.
@Bodigrim
Copy link
Contributor

Waiting for nomeata/inspection-testing#97...

There seems to be a genuine build failure at https://github.com/haskell/text/actions/runs/21018119841/job/60427258761?pr=685#step:3:705:

   cbits/hs_simdutf.c:1:10: error:
       fatal error: simdutf_c.h: No such file or directory
          1 | #include "simdutf_c.h"
            |          ^~~~~~~~~~~~~
    |
  1 | #include "simdutf_c.h"
    |          ^

@TerrorJack
Copy link
Contributor Author

i'm confused...the build works locally and in haskell-ci jobs, and the haskell-ci jobs have simdutf flag enabled by default right? i don't understand why there's a header not found error.

it can easily be worked around by just pasting the prototype and avoiding including simdutf_c.h, but maybe it's something more cursed going on here.

@Bodigrim
Copy link
Contributor

Emulated CI jobs are cursed indeed, I suppose one needs to adjust the incantation to pass GHC with all necessary files there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants