Skip to content

Conversation

@garyhtou
Copy link
Member

@garyhtou garyhtou commented Nov 8, 2024

The UI3 ship will comprise the following PRs (all combined into this PR):



TODO

BEFORE MERGING, REMOVE UI3 SPECIFIC CODE (THE TODO COMMENT)

@garyhtou garyhtou requested review from a team as code owners November 8, 2024 05:46
@garyhtou garyhtou marked this pull request as draft November 8, 2024 05:46
@garyhtou garyhtou temporarily deployed to bank-hackclu-ui3-zwdnyhwrc4vp8 November 8, 2024 05:50 Inactive
@dwahbe dwahbe marked this pull request as ready for review November 14, 2024 16:54
@dwahbe dwahbe marked this pull request as draft November 14, 2024 16:55
@garyhtou
Copy link
Member Author

The redesigned navigation as of #7828 isn't complete, but I've merged it into this branch so that it's easier for Lachlan to build their #7741 work on top of it.

@garyhtou garyhtou temporarily deployed to bank-hackclu-ui3-n47pu2ckurscq December 3, 2024 18:55 Inactive
@garyhtou garyhtou linked an issue Dec 13, 2024 that may be closed by this pull request
@manuthecoder manuthecoder requested a review from Copilot July 17, 2025 16:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive UI3 redesign for HCB, modernizing the interface with improved navigation, responsive design, and visual consistency. The changes encompass major layout restructuring, navigation component updates, and numerous styling improvements across the application.

  • Complete navigation redesign with mobile-responsive components
  • Modernized settings interfaces with new header components
  • Improved visual hierarchy and spacing throughout the application

Reviewed Changes

Copilot reviewed 138 out of 202 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
users/edit_*.html.erb Updates user settings navigation and header components
users/_*.html.erb New navigation components and user interface elements
events/*.html.erb Event-related UI improvements and navigation updates
application/_*.html.erb Core layout and component restructuring
layouts/*.html.erb Major layout overhauls for responsive design
Various view partials Styling improvements and component updates
Comments suppressed due to low confidence (1)

app/views/users/_payout_form.html.erb:35

  • [nitpick] The class name 'hidden' is too generic and could conflict with other CSS frameworks. Consider using a more specific class name like 'display-none' or 'payout-section-hidden'.
  <section data-behavior="check_payout_method_inputs" class="<%= "hidden" unless user.payout_method.instance_of?(User::PayoutMethod::Check) %>">

@manuthecoder manuthecoder marked this pull request as ready for review July 18, 2025 21:24
@manuthecoder
Copy link
Contributor

let the testing begin 🧙💣💥

@sampoder
Copy link
Member

A couple of quick things from me:

Screenshot 2025-07-19 at 11 05 42 PM

This feels really empty? Can we put HCB by Hack Club there or something?

The grant invitation feels like it needs a refresh:

Screenshot 2025-07-19 at 11 08 59 PM

I'll keep playing around with it over the next few days to find things!

@sampoder
Copy link
Member

Another quick thing!

Screenshot 2025-07-19 at 11 24 58 PM

@manuthecoder
Copy link
Contributor

image image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 133 out of 198 changed files in this pull request and generated 8 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

9 participants