-
Notifications
You must be signed in to change notification settings - Fork 125
feat: improve type search sorting with relevance-based ordering #7540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: improve type search sorting with relevance-based ordering #7540
Conversation
Sort type search results by match quality: exact matches first, prefix matches second, then alphabetical within each category.
Summary of ChangesHello @rickbijkerk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience within the Explorer's type search functionality. By introducing a relevance-based sorting algorithm, users can now find desired types more efficiently, as search results are intelligently ordered to prioritize exact and prefix matches, making type discovery intuitive and quick. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces relevance-based sorting for the type search in the Explorer, which is a great improvement for user experience. The implementation is solid. I've suggested a performance optimization using useDeferredValue to ensure the UI remains responsive even with large schemas, which aligns with the repository's style guide.
n1ru4l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickbijkerk Seems like it might make sense to use useDeferredValue as suggested by the AI review. I assume this can become a bit more expensive for bigger schemas?
|
Good point, changed it and re-pushed |
Background:
When searching for types in the Explorer type search dropdown, results weren't sorted by relevance. For example, searching for "Product" would show "CreatorProduct" before "Product" because the dropdown displayed results in their original order without considering match quality. This made it harder for users to find the exact type they were looking for.
Description:
Improved the type search sorting in the Explorer page to prioritize matches by relevance:
Files changed:
Checklist: