Skip to content

fix: annotate weighted edges dfs for mypy #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmeyerov merged 9 commits into from
Jan 28, 2026
Merged

fix: annotate weighted edges dfs for mypy #909

lmeyerov merged 9 commits into from
Jan 28, 2026

Conversation

@lmeyerov
Copy link
Contributor

@lmeyerov lmeyerov commented Jan 28, 2026 •
edited
Loading

Summary

  • annotate weighted edges df fields in PlotterBase to satisfy mypy type checking

Testing

  • ./bin/mypy.sh\n- ./bin/lint.sh

lmeyerov
lmeyerov commented Jan 28, 2026
View reviewed changes
graphistry/PlotterBase.py Outdated
self._weighted_edges_df_from_nodes = None
self._weighted_edges_df_from_edges = None
self._weighted_edges_df_from_nodes: Optional[pd.DataFrame] = None
self._weighted_edges_df_from_edges: Optional[pd.DataFrame] = None
Copy link
Contributor Author

@lmeyerov lmeyerov Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goes on Plottable

lmeyerov
lmeyerov commented Jan 28, 2026
View reviewed changes
@lmeyerov lmeyerov merged commit 63c7b32 into master Jan 28, 2026
31 checks passed
@lmeyerov lmeyerov deleted the fix/ci-master-red branch January 28, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lmeyerov