Skip to content

Conversation

@antongolub
Copy link
Collaborator

@antongolub antongolub commented Aug 18, 2025

continues #1320

  • Tests pass
  • Appropriate changes to README are included in PR

This comment was marked as outdated.

@antongolub antongolub requested a review from Copilot August 18, 2025 09:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CI workflow by extracting version resolution logic into a separate job that can be shared across publishing workflows. The changes improve maintainability by centralizing version computation and eliminating duplicated code across jobs.

  • Extracts version resolution logic into a dedicated version job
  • Removes duplicated version computation steps from individual publishing jobs
  • Standardizes environment variable usage across npm, JSR, and Docker publishing workflows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/publish.yml Adds version job and updates npm/docker publish jobs to use centralized version outputs
.github/workflows/dev-publish.yml Adds version job with dev-specific version formats and updates all publish jobs to use shared version data

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

path: |
build
jsr.json
package.json
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jsr.json file is being moved to a different position in the artifact path list. This change appears unrelated to the main purpose of the PR (extracting version resolution) and could potentially affect artifact behavior. Consider keeping the original order or documenting why this change is necessary.

Suggested change
package.json
package.json
jsr.json

Copilot uses AI. Check for mistakes.
@antongolub antongolub merged commit 51aed2e into google:main Aug 18, 2025
50 of 51 checks passed
@antongolub antongolub deleted the ci-ver-job branch August 18, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant