-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Modified _calculate_rouge_1_scores() to normalize texts before comparison and implemented _calculate_character_level_rouge() using Counter to calculate precision/recall/F-measure from character overlap #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robinpats182
wants to merge
3
commits into
google:main
Choose a base branch
from
robinpats182:fix-non-english-eval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Text utilities for evaluation.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import unicodedata | ||
|
|
||
|
|
||
| def normalize_text(text: str) -> str: | ||
| """Normalize text using NFC normalization and strip whitespace. | ||
|
|
||
| This ensures consistent text comparison across different Unicode | ||
| representations, which is particularly important for non-English text. | ||
|
|
||
| Args: | ||
| text: The text to normalize. | ||
|
|
||
| Returns: | ||
| The normalized text. | ||
| """ | ||
| return unicodedata.normalize("NFC", text).strip() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Tests for final_response_match_v1.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
|
|
||
| def test_normalization_applied_in_rouge(): | ||
| """Normalization should make identical Thai strings match.""" | ||
| from google.adk.evaluation.final_response_match_v1 import _calculate_rouge_1_scores | ||
| from google.adk.evaluation.text_utils import normalize_text | ||
|
|
||
| reference = "สวัสดี" | ||
| candidate = "สวัสดี" | ||
|
|
||
| # Verify normalization directly | ||
| assert normalize_text(reference) == normalize_text(candidate) | ||
|
|
||
| # Verify ROUGE score reflects a perfect match | ||
| score = _calculate_rouge_1_scores(candidate, reference) | ||
|
|
||
| assert score.precision == pytest.approx(1.0) | ||
| assert score.recall == pytest.approx(1.0) | ||
| assert score.fmeasure == pytest.approx(1.0) | ||
|
Comment on lines
+22
to
+38
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test is a good start for verifying the new character-level ROUGE scoring. To make it more robust and prevent future regressions, I recommend expanding the test suite. Consider parameterizing the test function to cover a wider range of scenarios, such as:
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks
if len(candidate) > 0andif len(reference) > 0are redundant. The guard clause on line 149 (if not reference or not candidate:) ensures that if this part of the code is reached, bothcandidateandreferenceare non-empty strings, so their lengths will be greater than 0. You can simplify the code by removing these checks.