-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(memory): add SQLite memory service #4116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
summerx96
wants to merge
2
commits into
google:main
Choose a base branch
from
summerx96:pr/sqlite-memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+772
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Memory Sample | ||
|
|
||
| This sample demonstrates memory usage with ADK. The included `main.py` uses | ||
| in-memory services for simplicity. For persistent local memory, use SQLite. | ||
|
|
||
| ## Persistent Local Memory (SQLite) | ||
|
|
||
| Programmatic usage: | ||
|
|
||
| ```python | ||
| from google.adk.memory.sqlite_memory_service import SqliteMemoryService | ||
| from google.adk.runners import Runner | ||
| from google.adk.sessions.in_memory_session_service import InMemorySessionService | ||
|
|
||
| memory_service = SqliteMemoryService(db_path="memory.db") | ||
| runner = Runner( | ||
| app_name="my_app", | ||
| agent=agent.root_agent, | ||
| session_service=InMemorySessionService(), | ||
| memory_service=memory_service, | ||
| ) | ||
| ``` | ||
|
|
||
| CLI usage (supported for `adk web` and `adk api_server`): | ||
|
|
||
| ```bash | ||
| adk web path/to/agents_dir --memory_service_uri=sqlite:///memory.db | ||
| ``` | ||
|
|
||
| Notes: | ||
| - `sqlite:///memory.db` uses a relative path. | ||
| - `sqlite:////abs/path/memory.db` uses an absolute path. | ||
| - `adk run` currently ignores `--memory_service_uri`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for handling
db_pathwhen it starts with/is to remove the leading slash. This implies that absolute paths are expected to be provided without the leading slash when passed toSqliteMemoryService. While this works, it might be more intuitive to handle bothsqlite:///path/to/dbandsqlite:////abs/path/to/db(whichurlparsewould parse as/abs/path/to/db) consistently by ensuringdb_pathis correctly interpreted as an absolute path if it starts with/after parsing, rather than stripping it. However, given the currentSqliteMemoryServiceexpectsdb_pathto be astrorPathand handlesPathobjects correctly, stripping the leading slash might be fine ifSqliteMemoryServiceinternally resolves relative paths from the current working directory or if thedb_pathis always expected to be relative unless explicitly handled as absolute by the caller.