fix: correct log condition for OpenSSL version detection #926
Conversation
dosubot
bot
added
the
size:XS
|
Related Documentation Checked 1 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull request overview
This PR fixes an incorrect conditional check in the OpenSSL version detection logic. The code was logging a success message when the version was not found (specific error), rather than when it was successfully detected (no error).
Changes:
- Corrected the log condition from checking for a specific error (
ErrProbeOpensslVerNotFound) to checking for success (err == nil)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return err | ||
| } | ||
| if errors.Is(err, ErrProbeOpensslVerNotFound) { | ||
| if err == nil { |
There was a problem hiding this comment.
The function of the original code is to judge that "the error is ErrProbeOpensslVerNotFound, when printing 241 lines of logs." ”
The current changes are not correct.
There was a problem hiding this comment.
OK. Based on my understanding of the code, if err is ErrProbeOpensslVerNotFound, then the verString variable will be empty, making it meaningless to print it.
I'll close this pr.
2 participants
No description provided.