Extract DocumentOutline from ScriptEditor #115346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the members overview / help overview from ScriptEditor and cleaned up the code.
I renamed it to outline to be a bit more accurate.
The functionality should be the same.
Unified the members overview and help overview ItemLists and methods.
There does not need to be separate ItemLists, only one is shown at a time and it doesn't store state.
There does not need to be multiple visibility methods, they were always called right after another and the logic is much simpler this way.
The visibility updating does not need to touch the filter and sort button individually, they are both in an HBoxContainer that can be used instead.
The current tab range check in
_update_help_overview_visibilityonly caught cases where no editor is open, but the next nullptr check would catch that anyway.The only information needed from the ScriptEditor is the current active editor (ScriptEditorBase or EditorHelp), I made a method for it.