Make memory profiling optional #113807
Merged
Make memory profiling optional #113807
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihe
force-pushed
the
optional-memory-profiling
branch
from
2882965 to
393daf6
Compare
akien-mga
reviewed
Dec 9, 2025
mihe
force-pushed
the
optional-memory-profiling
branch
from
393daf6 to
74ffb69
Compare
akien-mga
approved these changes
Dec 9, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to (but does not necessarily fix) #113805.
This introduces a new
profiler_track_memorybuild option, which lets you disable (no-op) theGodotProfileAllocandGodotProfileFreemacros, in order to omit whatever overhead those macros bring with them.This is mostly meant to be a stop-gap solution, to allow people to mitigate the rampant memory allocations that seem to be happening when using Tracy at the moment.
If this actually makes it to release somehow, we should probably have this new option beFalseby default, but I've left it asTrueso that people actually do run into this bug and can maybe provide more information and/or an MRP, assuming it isn't in fact unique to the project I'm working with for some odd reason.Note that this also fixes a build correctness issue with the generated
profiling.gen.h, where it wasn't being re-generated if you changed the value ofprofiler_sample_callstack, due to its value not being passed in toCommandNoCache.