proc: fix defer loading in go 1.26 #4195
Draft
+124
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.26 removed the 'pc' field from the _defer struct. Use the defer wrapper function, when available to discover the line where the defer was created. For every other case leave the field empty without crashing. Also disables capslock check on everything except the latest minor version of Go (because the output can change)
Member
|
That patch got reverted upstream, holding off until it lands again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.26 removed the 'pc' field from the _defer struct. Use the defer
wrapper function, when available to discover the line where the defer
was created. For every other case leave the field empty without
crashing.
Also disables capslock check on everything except the latest minor
version of Go (because the output can change)