Skip to content

Conversation

@sergeymatov
Copy link
Contributor

@sergeymatov sergeymatov commented Dec 11, 2025

Embedded BMP Server to track FRR BGP peering information

  • Populate DataplaneStatus internal implementation and it's k8s interface
  • BMP server configuration via command line arguments during the startup of the dataplane
  • FRR BMP config renderer and builder
  • BMP server running in separate runtime in router to manage connections from FRR
  • BMP decoder and DataplaneStatus update handler

@sergeymatov sergeymatov requested a review from a team as a code owner December 11, 2025 13:00
@sergeymatov sergeymatov requested review from Fredi-raspall and removed request for a team December 11, 2025 13:00
@sergeymatov sergeymatov marked this pull request as draft December 11, 2025 13:00
@sergeymatov sergeymatov force-pushed the pr/smatov/bmp-frr-config branch from 43e8d27 to 6044efa Compare December 11, 2025 13:01
@Fredi-raspall Fredi-raspall self-requested a review December 12, 2025 10:50
Copy link
Contributor

@Fredi-raspall Fredi-raspall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach and implementation!
I am going to request changes because I'd like to review this again once it is no longer a draft and some of the questions get clarified.
Thanks!

@sergeymatov sergeymatov force-pushed the pr/smatov/bmp-frr-config branch 2 times, most recently from 66e7168 to 613b990 Compare December 15, 2025 08:07
@mvachhar mvachhar closed this Dec 15, 2025
@mvachhar mvachhar reopened this Dec 15, 2025
@sergeymatov sergeymatov force-pushed the pr/smatov/bmp-frr-config branch 2 times, most recently from 4ce4148 to eeea2b2 Compare December 16, 2025 14:20
@sergeymatov sergeymatov force-pushed the pr/smatov/bmp-frr-config branch 6 times, most recently from 039ec5d to 91ecd2f Compare January 26, 2026 14:38
Copy link
Contributor

@mvachhar mvachhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved, I'm good to go with this. @daniel-noland can you please rereview today so we can merge this?

@mvachhar mvachhar dismissed daniel-noland’s stale review January 27, 2026 15:31

Sorry, we have two approvals and I think this is good enough.

@mvachhar mvachhar added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 27, 2026
@sergeymatov sergeymatov force-pushed the pr/smatov/bmp-frr-config branch from 91ecd2f to 1d87b6b Compare January 27, 2026 15:50
@mvachhar mvachhar enabled auto-merge January 27, 2026 15:52
@mvachhar mvachhar added this pull request to the merge queue Jan 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 27, 2026
@sergeymatov sergeymatov added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 499aac5 Jan 28, 2026
32 of 34 checks passed
@sergeymatov sergeymatov deleted the pr/smatov/bmp-frr-config branch January 28, 2026 08:20
@qmonnet
Copy link
Member

qmonnet commented Jan 28, 2026

$ git show 7e32cd0eadda -- Cargo.toml
commit 7e32cd0eadda037f8f50a24dc3be54476d08edde
Author: Sergey Matov <[email protected]>
Date:   Tue Dec 9 14:50:05 2025 +0400

    feat(stats): BMPv3 implementation, cli and mgmt adjustments
    
    Signed-off-by: Sergey Matov <[email protected]>
    
    Signed-off-by: Sergey Matov <[email protected]>

diff --git a/Cargo.toml b/Cargo.toml
index 323421b542cd..10f776612f5f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -181,17 +181,11 @@ strum_macros = { version = "0.27.2", default-features = false, features = [] }
 syn = { version = "2.0.114", default-features = false, features = [] }
 thiserror = { version = "2.0.18", default-features = false, features = [] }
 thread_local = { version = "1.1.9", default-features = false, features = [] }
-<<<<<<< HEAD
 tokio = { version = "1.49.0", default-features = false, features = [] }
 tokio-stream = { version = "0.1.18", default-features = false, features = [] }
 tracing = { version = "0.1.44", default-features = false, features = [] }
-=======
-tokio = { version = "1.48.0", default-features = false, features = [] }
-tokio-stream = { version = "0.1.17", default-features = false, features = [] }
 tokio-util = { version = "0.7.13", default-features = false, features = ["codec"] }
 tonic = { version = "0.14.2", default-features = false, features = [] }
-tracing = { version = "0.1.43", default-features = false, features = [] }
->>>>>>> 71f0b9f2 (feat(status): Populate routing and mgmt with BMP params)
 tracing-error = { version = "0.2.1", default-features = false, features = [] }
 tracing-subscriber = { version = "0.3.22", default-features = false, features = [] }
 tracing-test = { version = "0.2.5", default-features = false, features = [] }

😬 These merge markers should never appear in the final git history, please let's be careful next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:-upgrade Disable VLAB upgrade tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants