feat(admin): add unit formatting for emerge categories in admin provisioning #106941
+86
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add utility functions for emerge data categories (SIZE_ANALYSIS, INSTALLABLE_BUILD) to support unit formatting in admin UI. - isEmergeCategory(): identifies emerge billing categories - getCategoryUnitSuffix(): returns appropriate unit suffix for all category types (GB, hours, builds, installs) Includes comprehensive tests for both functions. BIL-1928
Fix naming inconsistencies in BILLED_DATA_CATEGORY_INFO: - SIZE_ANALYSIS: "upload" → "build" - INSTALLABLE_BUILD: "distribution" → "install" BIL-1928
Replace inline isByteCategory check with getCategoryUnitSuffix helper to support unit suffixes for all category types including emerge categories (builds, installs). BIL-1928
Add unit formatting support for emerge categories in the gift events admin modal: - Add isEmergeCategory check in getLabel() for proper labeling - Add SIZE_ANALYSIS handling with "build/builds" suffix - Add INSTALLABLE_BUILD handling with "install/installs" suffix BIL-1928
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-1928/add-formatting-for-admin-provisioning
Summary
Adds unit formatting for emerge data categories (SIZE_ANALYSIS, INSTALLABLE_BUILD) in the admin provisioning UI:
isEmergeCategory()andgetCategoryUnitSuffix()helper functions indataCategory.tsxshortenedUnitNamevalues: "upload" → "build", "distribution" → "install"Test plan
isEmergeCategory()andgetCategoryUnitSuffix()