fix(environments): Handle missing default environment in event processing #106937
+14
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue SENTRY-434K, where
Environment.DoesNotExisterrors occurred during thelink_event_to_user_reportpipeline step insentry.issues.tasks.post_process.post_process_group.The root cause was identified as
event.get_environment()attempting to retrieve anEnvironmentrecord with an empty string name (when an event lacked an explicit environment tag). If this default empty-string environment had never been implicitly created for a given organization, the.get()call would fail.The solution modifies
BaseEvent.get_environment()insrc/sentry/services/eventstore/models.py. Instead of directly callingEnvironment.get_for_organization_id()which uses a.get()query, it now wraps this call in atry-except Environment.DoesNotExistblock. If the environment does not exist, it falls back toEnvironment.objects.get_or_create(name=name, organization_id=organization_id), ensuring the default empty-string environment is created if it's missing. This makes the environment lookup more robust and prevents theDoesNotExisterror.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.