Lazily start TelemetryEventBuffer threads #2832
Merged
+19
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sl0thentr0py
commented
Jan 13, 2026
sl0thentr0py
commented
- resolves: Start logs and metric threads in add instead of on instantiation #2821
- resolves: RUBY-133
sl0thentr0py
force-pushed
the
neel/telemetry-buffer-thread-lazy
branch
from
d9b815c to
44d16c0
Compare
sl0thentr0py
changed the title
TelemetryEventBuffers
sl0thentr0py
force-pushed
the
neel/telemetry-buffer-thread-lazy
branch
2 times, most recently
from
9dbcb30 to
bb111d9
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/telemetry-buffer-thread-lazy
branch
from
bb111d9 to
a17ef56
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
solnic
requested changes
Jan 13, 2026
Collaborator
solnic
left a comment
solnic
left a comment
There was a problem hiding this comment.
Some 💅🏻 changes only - would be nice to address them before merging
sentry-ruby/spec/support/shared_examples_for_telemetry_event_buffers.rb
Outdated
Show resolved
Hide resolved
sl0thentr0py
force-pushed
the
neel/telemetry-buffer-thread-lazy
branch
from
a17ef56 to
f81ff89
Compare
solnic
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.