-
-
Notifications
You must be signed in to change notification settings - Fork 465
feat(metrics): [Trace Metrics 4] Add transport types for metrics #4983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/trace-metrics
Are you sure you want to change the base?
feat(metrics): [Trace Metrics 4] Add transport types for metrics #4983
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- [Trace Metrics 4] Add transport types for metrics ([#4983](https://github.com/getsentry/sentry-java/pull/4983))If none of the above apply, you can opt out of this check by adding |
ede7fc3 to
d7a5d68
Compare
d662aca to
c5710d1
Compare
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| public final class SentryMetricsEvents implements JsonUnknown, JsonSerializable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some serialization/deserialization tests for this would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in #5005
c5710d1 to
d3c7452
Compare
d7a5d68 to
14ea96a
Compare
|
cursor review |
|
@sentry review |
|
|
||
| public final class SentryMetricsEvent implements JsonUnknown, JsonSerializable { | ||
|
|
||
| private @NotNull SentryId traceId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing getter for traceId field
Medium Severity
The traceId field in SentryMetricsEvent is declared but has no getter or setter methods. This is inconsistent with the spanId field in the same class which has both getSpanId() and setSpanId() accessors. Users implementing BeforeSendMetricCallback cannot programmatically access the trace ID of individual metrics events to inspect or filter them based on trace context.

📜 Description
Add
SentryMetricsEventsandSentryMetricsEventtransport types.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps