-
-
Notifications
You must be signed in to change notification settings - Fork 376
ref: Remove unnecessary @objcMembers and @objc annotations #7305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Remove @objcMembers from SentryViewRendererV2 and SentryDefaultViewRenderer as they are not used from Objective-C code (only conform to @objc protocol) - Make SentryViewRendererV2 and SentryDefaultViewRenderer internal since they are implementation details not exposed in the public API - Remove @objcMembers from SentryANRStoppedResult as it is only used from Swift - Remove redundant @objc from SentryLog since @objcMembers already exposes the class to Objective-C
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7305 +/- ##
=============================================
- Coverage 85.518% 85.061% -0.457%
=============================================
Files 471 471
Lines 28450 28450
Branches 12478 12481 +3
=============================================
- Hits 24330 24200 -130
- Misses 4067 4204 +137
+ Partials 53 46 -7
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a7d7fb6 | 1209.53 ms | 1235.91 ms | 26.38 ms |
| 79e2bb8 | 1216.37 ms | 1242.42 ms | 26.05 ms |
| 64a365a | 1225.60 ms | 1255.49 ms | 29.89 ms |
| 47c9f79 | 1216.57 ms | 1240.94 ms | 24.37 ms |
| 98a16ef | 1227.45 ms | 1258.19 ms | 30.74 ms |
| 84bc307 | 1211.52 ms | 1237.09 ms | 25.56 ms |
| a424cf3 | 1231.36 ms | 1259.62 ms | 28.25 ms |
| b87b34f | 1203.00 ms | 1237.17 ms | 34.17 ms |
| 1a887e2 | 1212.46 ms | 1241.33 ms | 28.87 ms |
| 58a9225 | 1211.40 ms | 1238.88 ms | 27.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a7d7fb6 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 79e2bb8 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 64a365a | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 47c9f79 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| 98a16ef | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 84bc307 | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| a424cf3 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| b87b34f | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 1a887e2 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 58a9225 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#skip-changelog
Closes #7306