-
Notifications
You must be signed in to change notification settings - Fork 190
games-util/hydra-launcher-bin: new package, add 3.8.1 #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added metadata.xml for Hydra game launcher with maintainer and description.
Remove QA_PREBUILT variable from ebuild file.
|
Thank you for your interest in contributing to GURU. I left some comments to improve the ebuild. Also, to add new package, please, follow the instructions from https://wiki.gentoo.org/wiki/Project:GURU/Information_for_Contributors and ensure that the maintainer email in the metadata.xml match the email you used to register on Bugzilla. We generally don't merge PR for new packages. |
Kinda copied this from vesktop-bin's ebuild I'ma be honest with y'all
Gur0v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed chrome-sandbox permissions to match other Electron apps (using 4711 + explicit fowners root). Added RESTRICT=mirror. Switched to unpacker eclass with rpmunpack instead of manual rpm2tar conversion.
Gur0v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inherited rpm eclass for automatic RPM extraction. Added -* to KEYWORDS and wrapped SRC_URI with amd64?. Switched to find. Added net-misc/aria2 dependency to use system package instead of bundled version.
|
From pkgcheck scan: (you should depend on virtual/zlib instead) And some other QA warnings: Because the ebuild only supports amd64 you could just remove the binary libraries for unsupported architectures. Also, remember to use the standard commit format |
A game launcher that allows you to download, play, track your stats and manage your games all in one place.
Upstream: https://github.com/hydralauncher/hydra