add package openlitespeed #316

KotoishiHeart · 2025-04-28T13:36:07Z

What to do if you don't have php and eselect-php support?

stkw0 · 2025-04-30T08:12:20Z

What to do if you don't have php and eselect-php support?

Can you explain a bit more what do you mean? What are you trying to achieve and how is openlitespeed related?

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

stkw0 · 2025-04-30T08:16:59Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+
+LICENSE="MIT"
+SLOT="0"
+KEYWORDS="~amd64 ~arm64"


I don't know if it's the case. Just a reminder that only the arch that have been tested should be added to KEYWORDS.

Since openlitespeed supports ARM, I don't think there's any problem. I confirmed that I can build it.

This is a common confusion. Even if upstream supports it,if it has not been personally tested it should not be added. In this case it's okay since you tested it.

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

KotoishiHeart · 2025-04-30T12:22:11Z

Can you explain a bit more what do you mean? What are you trying to achieve and how is openlitespeed related?

Openlitespeed requires a special php that supports litespeed.
The currently available PHP is not compatible with Litespeed.
The default PHP provided by openlitespeed is version 5.6 with no support.

Openlitespeed cannot be run with just the ebuild you add.
Is it possible to put openlitespeed in guru?

demize · 2025-05-02T01:10:19Z

Openlitespeed requires a special php that supports litespeed.

It looks like PHP has support for litespeed, but it needs to be enabled at compile-time. The best solution would be to submit a separate pull request to ::gentoo, adding a litespeed USE flag so that this package can depend on dev-lang/php[litespeed].

Unfortunately I don't think the alternative solutions to provide PHP are good fits for GURU, since they would mean either creating an entirely separate PHP ebuild in ::guru solely to support litespeed, bundling a custom build of PHP with openlitespeed, or expecting the user to provide their own PHP installation.

Theoretically you could add openlitespeed without providing any PHP support, but I'd probably try to get a USE flag added in ::gentoo first, since otherwise it leaves potential users in an awkward situation here.

KotoishiHeart · 2025-05-03T02:31:06Z

As a workaround until litespeed support is added, would it be better to install the official lsphp8.1 package for ubuntu?

demize · 2025-05-08T14:12:22Z

As a workaround until litespeed support is added, would it be better to install the official lsphp8.1 package for ubuntu?

Ultimately this is just a webserver, so I don’t think we should block adding it because there’s no easy way to build support for it with PHP in ::gentoo.

I don’t think we can add or include our own PHP server in ::guru, either as part of this package or as its own package, since it would conflict with the duplicates policy. And I don’t want to hold this up myself, so if we can add it without any PHP support (unless the user installs a custom build), I think that’s fine for now. Did you (or are you planning to) open a PR in ::gentoo to add the USE flag?

Either way, @stkw0 has provided a lot more feedback already, so if he doesn’t have any objections to adding as-is then don’t worry about me :)

stkw0 · 2025-05-08T16:14:58Z

I think it's worthy to send a PR to ::gentoo adding the litespeed support, as it may be useful for other cases and would simplify things. Mixing a source ebuild and a pre-built binary from Ubuntu is a bit of a mess.

btw the current PR still has a number of issues (will add some more comments). There is no sign-off tag and there are two Metadata files for acct-user and acct-group ebuilds that should not be there.
Is there a need to add both, openlitespeed version 1.8.1 and version 1.8.3.1?

stkw0 · 2025-05-08T16:16:00Z

www-servers/openlitespeed/files/openlitespeed-disable-build-deps-libs.patch

+-OPTION(MOD_PAGESPEED "Whether pagespeed should be built" ${LINUX_X64})
+-OPTION(MOD_SECURITY "Whether mod_security should be built" ${NOT_MACOS})
+-OPTION(MOD_LUA "Whether Lua should be built" ${LINUX_X64})
+OPTION(MOD_PAGESPEED "Whether pagespeed should be built" OFF)


this should be passed to mycmakeargs instead of being patched here

stkw0 · 2025-05-08T16:17:49Z

www-servers/openlitespeed/files/openlitespeed-add-install-files.patch

@@ -0,0 +1,84 @@
+I plan to eventually change the patch to install openlitespeed in the appropriate location instead of installing it in /usr/local/lsws/.


yeah. This should be fixed before merging this. Nothing should be installed in /usr/local directory.
Usually web pages read-only data is stored in /usr/share

A bit of reference in case it's useful:

https://cmake.org/cmake/help/latest/command/install.html

https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html

stkw0 · 2025-05-08T16:27:59Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+	fi
+	OPENLSWS_EXAMPLEPORT=8088
+
+	sed -e "s/%ADMIN_PORT%/$OPENLSWS_ADMINPORT/" "${S}/dist/admin/conf/admin_config.conf.in" > "${S}/dist/admin/conf/admin_config.conf" || die


Maybe it might be better to move all this configuration part to pkg_config and print an informational message about it. Something similar to what postgresql ebuild does

KotoishiHeart · 2025-05-09T11:09:25Z

Is there a need to add both, openlitespeed version 1.8.1 and version 1.8.3.1?

There's no need. It works only with Version 1.8.3.1.

Did you (or are you planning to) open a PR in ::gentoo to add the USE flag?

I don't have the code knowledge to open a PR to add the litespeed flag to "eselect-php" or "php", and I don't have the time to do the work for that.
It might be possible if you do it for a long time, but other developers might be faster to change it.

stkw0 · 2025-05-09T12:18:27Z

There's no need. It works only with Version 1.8.3.1.

Then please, remove the other one.

I don't have the code knowledge to open a PR to add the litespeed flag to "eselect-php" or "php", and I don't have the time to do the work for that.
It might be possible if you do it for a long time, but other developers might be faster to change it.

I just opened a PR to add litespeed USE to php: gentoo/gentoo#42003

thesamesam · 2025-06-16T20:08:20Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+	dev-libs/ls-hpack:=[static-libs=]
+"
+
+RDEPEND="


Several libraries are missing from RDEPEND here.

thesamesam · 2025-06-16T20:08:24Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+KEYWORDS="~amd64 ~arm64"
+
+IUSE="static-libs ruby systemd"
+RESTRICT=""


thesamesam · 2025-06-16T20:08:40Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+IUSE="static-libs ruby systemd"
+RESTRICT=""
+
+DEPEND="


Unsorted contents. Also, conditionals inside should go last.

thesamesam · 2025-06-16T20:08:44Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+	sed "s:%LSWS_CTRL%:$SERVERROOT/bin/lswsctrl:" "${S}/dist/admin/misc/lsws.rc.gentoo.in" > "${S}/dist/admin/misc/lsws.rc.gentoo" || die
+	sed "s:%LSWS_CTRL%:$SERVERROOT/bin/lswsctrl:" "${S}/dist/admin/misc/lshttpd.service.in" > "${S}/dist/admin/misc/lshttpd.service" || die
+
+	local mycmakeargs=(


thesamesam · 2025-06-16T20:08:58Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+}
+
+src_install() {
+	default


This should surely be cmake_src_install.

thesamesam · 2025-06-16T20:09:06Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+
+src_install() {
+	default
+	systemd_dounit "${D}"/admin/misc/lshttpd.service || die


ED, not D, but no need for die here (it dies for us).

thesamesam · 2025-06-16T20:09:16Z

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild

+	app-arch/brotli
+	dev-libs/yajl
+	virtual/libcrypt
+	ruby? ( dev-lang/ruby )


This is unlikely to be right by itself and should use an eclass.

stkw0 reviewed Apr 30, 2025

View reviewed changes

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild Outdated Show resolved Hide resolved

stkw0 reviewed Apr 30, 2025

View reviewed changes

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild Outdated Show resolved Hide resolved

stkw0 reviewed Apr 30, 2025

View reviewed changes

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild Outdated Show resolved Hide resolved

stkw0 reviewed Apr 30, 2025

View reviewed changes

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild Outdated Show resolved Hide resolved

stkw0 reviewed Apr 30, 2025

View reviewed changes

www-servers/openlitespeed/openlitespeed-1.8.3.1.ebuild Outdated Show resolved Hide resolved

KotoishiHeart force-pushed the add_openlitespeed branch 2 times, most recently from a2ed505 to 8289339 Compare April 30, 2025 12:44

stkw0 reviewed May 8, 2025

View reviewed changes

stkw0 mentioned this pull request May 9, 2025

dev-lang/php: add litespeed USE gentoo/gentoo#42003

Closed

4 tasks

KotoishiHeart force-pushed the add_openlitespeed branch from 8289339 to 93d4153 Compare May 9, 2025 13:57

www-servers/openlitespeed: add package openlitespeed

8245d30

KotoishiHeart force-pushed the add_openlitespeed branch from 93d4153 to 8245d30 Compare May 9, 2025 13:58

thesamesam suggested changes Jun 16, 2025

View reviewed changes

		@@ -0,0 +1,84 @@
		I plan to eventually change the patch to install openlitespeed in the appropriate location instead of installing it in /usr/local/lsws/.

add package openlitespeed #316

Are you sure you want to change the base?

add package openlitespeed #316

Uh oh!

Conversation

KotoishiHeart commented Apr 28, 2025

Uh oh!

stkw0 commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

KotoishiHeart commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

demize commented May 2, 2025

Uh oh!

KotoishiHeart commented May 3, 2025

Uh oh!

demize commented May 8, 2025

Uh oh!

stkw0 commented May 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stkw0 May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KotoishiHeart commented May 9, 2025

Uh oh!

stkw0 commented May 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KotoishiHeart commented Apr 30, 2025 •

edited

Loading

stkw0 May 8, 2025 •

edited

Loading