Skip to content

Conversation

@acumino
Copy link
Member

@acumino acumino commented Nov 17, 2025

What this PR does / why we need it:
Adds a check to ensure the new machine set is scaled up when the combined replicas of old and new machine sets are less than the desired deployment replicas. This basically ensures that if a machine is deleted manually from the old machine sets, a new machine should be created in the new machine set with the updated configuration.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed an issue where deleting a machine from an old MachineSet could prevent proper scaling. The new MachineSet now scales up when total replicas (old + new) drop below the desired count, ensuring replacements are created with the updated configuration.

@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2025
@acumino acumino marked this pull request as ready for review November 17, 2025 14:18
@acumino acumino requested a review from a team as a code owner November 17, 2025 14:18
Copy link
Member

@elankath elankath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Dec 16, 2025
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2025
@aaronfern
Copy link
Member

/remove-lifecycle stale

@gardener-robot
Copy link

@aaronfern Command /remove-lifecycle is not known.

@aaronfern aaronfern removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2026
Copy link
Member

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jan 6, 2026
Copy link
Member

@takoverflow takoverflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@takoverflow takoverflow dismissed elankath’s stale review January 8, 2026 05:52

Already addressed review comments

@takoverflow takoverflow merged commit 0e10987 into gardener:master Jan 8, 2026
12 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 8, 2026
@acumino acumino deleted the fix-scale branch January 8, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed/lgtm Has approval for merging size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants