Skip to content

fix ImmutableMatrix for IsMatrixObj #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 2 commits into from
Jan 12, 2026
Merged

fix ImmutableMatrix for IsMatrixObj #6186

fingolfin merged 2 commits into from
Jan 12, 2026
+28 −4

Conversation

@ThomasBreuer
Copy link
Contributor

@ThomasBreuer ThomasBreuer commented Jan 8, 2026

According to the documentation, ImmutableMatrix does the same as ChangedBaseDomain if the 2nd argument is in IsMatrixObj. This was not the case up to now.

(And we are allowed to call MakeImmutable instead of Immutable if the 3rd argument is true.)

@ThomasBreuer
fix ImmutableMatrix for IsMatrixObj
7228d35 
According to the documentation, `ImmutableMatrix` does the same as
`ChangedBaseDomain` if the 2nd argument is in `IsMatrixObj`.
This was not the case up to now.

(And we are allowed to call `MakeImmutable` instead of `Immutable`
if the 3rd argument is `true`.)
@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jan 8, 2026
@ThomasBreuer
Copy link
Contributor Author

ThomasBreuer commented Jan 9, 2026

When copying the proposed change to hpcgap/lib/vecmat.gi, I noticed that some changes from lib/vecmat.gi seem to be missing there, such as the addition of new methods for SwapMatrixRows and SwapMatrixColumns (from #5837). Perhaps some tests should be added, and the CI tests with hpcgap can detect that something went wrong?
If yes then I can fix the "divergence" (in another pull request).

@ThomasBreuer ThomasBreuer requested a review from fingolfin January 9, 2026 12:56
@ThomasBreuer ThomasBreuer mentioned this pull request Jan 9, 2026
Merged
@fingolfin fingolfin merged commit 7e76a45 into gap-system:master Jan 12, 2026
32 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_ImmutableMatrix branch January 13, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees

No one assigned

Labels

kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ThomasBreuer @fingolfin