Skip to content

Conversation

@airhorns
Copy link
Contributor

@airhorns airhorns commented Apr 1, 2025

We're already mutating the descriptors here, may as well define em all in bulk instead of one at a time on a new object

@airhorns airhorns force-pushed the faster-self-define branch from 2bd9096 to 0328387 Compare April 1, 2025 21:35
@airhorns airhorns force-pushed the faster-self-define branch from 55289a4 to 91012b7 Compare April 1, 2025 21:39
@airhorns airhorns marked this pull request as ready for review April 1, 2025 21:39
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #112 will improve performances by 34.5%

Comparing faster-self-define (91012b7) with faster-self-define (55289a4)

Summary

⚡ 2 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
instantiating a large union 62.5 µs 52.9 µs +18.05%
accessing unmemoized null property of a class model 12.2 µs 9.1 µs +34.5%

@airhorns airhorns merged commit 3552255 into main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants