-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(course): resolve deletion failure for enrolled courses #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raizasafeel
wants to merge
7
commits into
frappe:develop
Choose a base branch
from
raizasafeel:fix/course-deletion
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
fix/course-deletion
|
| Run status |
|
| Run duration | 01m 06s |
| Commit |
|
| Committer | Raizaaa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
2
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1998 +/- ##
===========================================
+ Coverage 32.85% 33.17% +0.32%
===========================================
Files 152 153 +1
Lines 5108 5116 +8
===========================================
+ Hits 1678 1697 +19
+ Misses 3430 3419 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ca83b06 to
e5bd877
Compare
e5bd877 to
2abc243
Compare
af8dc82 to
0d8c1c1
Compare
0d8c1c1 to
909d272
Compare
909d272 to
8bf896f
Compare
65334b1 to
cc3cb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Course deletion was not working for those with student enrollment and progress. It has been fixed.
Related Issue
Closes #1929