Skip to content

Conversation

@raizasafeel
Copy link
Contributor

Summary

Course deletion was not working for those with student enrollment and progress. It has been fixed.

Related Issue

Closes #1929

@cypress
Copy link

cypress bot commented Jan 16, 2026

lms    Run #1976

Run Properties:  status check passed Passed #1976  •  git commit adc6985a9f ℹ️: Merge aeb2724e82e5d2cdcc550c2c9ed0ec13852c325e into b429fb2e47b682cc74cdacf3f9d9...
Project lms
Branch Review fix/course-deletion
Run status status check passed Passed #1976
Run duration 01m 06s
Commit git commit adc6985a9f ℹ️: Merge aeb2724e82e5d2cdcc550c2c9ed0ec13852c325e into b429fb2e47b682cc74cdacf3f9d9...
Committer Raizaaa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 94.14634% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.17%. Comparing base (5175050) to head (aeb2724).
⚠️ Report is 73 commits behind head on develop.

Files with missing lines Patch % Lines
lms/lms/test_helpers.py 89.56% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1998      +/-   ##
===========================================
+ Coverage    32.85%   33.17%   +0.32%     
===========================================
  Files          152      153       +1     
  Lines         5108     5116       +8     
===========================================
+ Hits          1678     1697      +19     
+ Misses        3430     3419      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raizasafeel raizasafeel force-pushed the fix/course-deletion branch 5 times, most recently from af8dc82 to 0d8c1c1 Compare January 22, 2026 10:14
@raizasafeel raizasafeel force-pushed the fix/course-deletion branch 2 times, most recently from 65334b1 to cc3cb7a Compare January 23, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't delete course because it's associated to LMS enrolment

3 participants