Skip to content

fix lost default volume_type after creating LVM volume #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mxey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix lost default volume_type after creating LVM volume #173

mxey wants to merge 1 commit into from

Conversation

@mxey
Copy link

@mxey mxey commented May 19, 2025

fixes #169

See #172 (comment) for a reproducer of the bug

@mxey mxey force-pushed the lvm-volume-type branch from 467ecb3 to baeacbf Compare May 19, 2025 12:56
ekohl
ekohl requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my research I found we shouldn't actually set this in various cases. #172 is IMHO a much more robust fix to it. 👎 to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekohl ekohl ekohl requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Volume loses its format_type when saved

2 participants

@mxey @ekohl