Optimize XML parsing in loops #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the method so it only parses the XML once instead of 4 times. It adds basic tests to avoid regressions.
This uses the Nokogiri feature to directly query an attribute by its path to avoid needing to retrieve it. Especially in list_domains this avoids the need to parse the same XML over and over again.
ekohl
force-pushed
the
reduce-util-class
branch
from
f5e6927 to
18dc35a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In various places the XML is parsed over and over again. This replaces the use of xml_element and xml_elements with better alternatives. It also removes unused requires from the util class, reducing it to just random name generation.