-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Upgrade Jaspr to latest release #12806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant upgrade of the Jaspr web framework to version 0.22.0. The core changes involve migrating the existing codebase to align with the new Jaspr API, which includes separating client and server configurations and updating component rendering syntax. This ensures the application leverages the latest capabilities of Jaspr and maintains a modern, efficient architecture. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Visit the preview URL for this PR (updated for commit 1d0232b): https://flutter-docs-prod--pr12806-chore-upgrade-jaspr-6k2nfs99.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades Jaspr to version 0.22.0 and migrates the codebase to align with the new API. The changes are extensive and touch many files, primarily updating component creation syntax (e.g., text() to .text(), raw() to RawText()) and splitting the application into server and client entry points, which is a significant improvement for code organization.
My main concern is the re-implementation of the RawNode component in site/lib/src/components/util/retake_element_web.dart. This creates a dependency on Jaspr's internal implementation, which could be a maintenance risk. I've left a specific comment with suggestions on how to address this.
Other than that, the migration appears to be thorough and correct. The code is cleaner in many places due to the adoption of new syntax and patterns from the latest Jaspr release.
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting! Thanks for the great release and this update!
Once you have a chance, can you complete it for dart.dev as well?
Updates jaspr to 0.22.0 and migrates everything.
Presubmit checklist
of 80 characters or fewer.