Allow seeing different assembly code for the same function #5349
+237
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
assembly-view-prev-next
branch
from
49d95a4 to
139d000
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
139d000 to
74b06df
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
74b06df to
39b83d2
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
39b83d2 to
7ea21d4
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
7ea21d4 to
4112ac4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5349 +/- ##
==========================================
+ Coverage 85.71% 85.75% +0.04%
==========================================
Files 317 318 +1
Lines 31216 31240 +24
Branches 8499 8600 +101
==========================================
+ Hits 26756 26790 +34
+ Misses 4030 4020 -10
Partials 430 430 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
assembly-view-prev-next
branch
2 times, most recently
from
f88be1c to
8ecd06e
Compare
mstange
added a commit
that referenced
this pull request
Jan 19, 2026
A small behavior-neutral change that I've extracted from #5349.
mstange
added a commit
that referenced
this pull request
Jan 19, 2026
…iew (#5759) [Production](https://share.firefox.dev/4qXrKoY) | [Deploy preview](https://deploy-preview-5759--perf-html.netlify.app/public/f2eatktw200exzsbzps5xg0gpjkb785cjj1yz8r/calltree/?globalTrackOrder=a0978465312&hiddenGlobalTracks=0w8a&hiddenLocalTracksByPid=46164-0w3~46165-0~46175-0~46171-0~46589-0~46180-0~46588-0~46174-0~46168-01~46177-0&range=m29020&thread=e&transforms=ff-1037~ff-1046&v=12) Fixes #5758 and cleans things up a bit. Having the samples passed to `getBottomBoxInfoForCallNode` will also make it easier to address the TODO about picking the native symbol with the highest sample count, but I'll do that in a separate PR (or probably as part of #5349).
mstange
force-pushed
the
assembly-view-prev-next
branch
from
8ecd06e to
1a8f46a
Compare
Contributor
Author
|
This is now ready for review. |
mstange
changed the title
flodolo
approved these changes
Jan 23, 2026
canova
reviewed
Jan 23, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Nice! Looks good to me, but can we also make the x of y text in the UI localizable?
| return ( | ||
| <> | ||
| <h3 className="bottom-box-title-trailer"> | ||
| {index !== null && count > 1 ? `${index + 1} of ${count}` : ''} |
Member
There was a problem hiding this comment.
Can we also make the x of y string localizable?
Contributor
Author
There was a problem hiding this comment.
Oh right! Added a commit for that.
| return ( | ||
| <> | ||
| <h3 className="bottom-box-title-trailer"> | ||
| {index !== null && count > 1 ? `${index + 1} of ${count}` : ''} |
Member
There was a problem hiding this comment.
Also, index !== null shouldn't be reachable now thanks to the early return above. We can remove it.
flodolo
requested changes
Jan 23, 2026
mstange
force-pushed
the
assembly-view-prev-next
branch
from
1a8f46a to
4a535bc
Compare
mstange
force-pushed
the
assembly-view-prev-next
branch
from
4a535bc to
65dfc52
Compare
flodolo
approved these changes
Jan 23, 2026
mstange
force-pushed
the
assembly-view-prev-next
branch
from
65dfc52 to
c3eaddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview - Double-click the first row in the call tree and then click the
asmbuttonIf a JS function is JIT compiled multiple times, then it's currently impossible to see the assembly code for each compilation. If you double-click the call node for the function, the assembly view shows an arbitrary compilation. It doesn't even try to find the one with the highest sample count. The same is true for functions that were inlined into multiple different functions.
This PR allows navigating between the different compilations.
I'll make a separate PR to pick the native symbol with the highest sample count.