Revert "[chore] Release 4.19.0" #744
Conversation
This reverts commit 3a86709.
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a revert of a previous release, specifically rolling back the Firebase Go Admin SDK version. This action is typically taken to address issues discovered shortly after a release, ensuring stability by returning to a known good state. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the SDK version from 4.19.0 to 4.18.0. The change to the version constant in firebase.go is correct. However, I've raised a high-severity concern that this revert might be incomplete. Release commits often modify more than just the version string, and failing to revert all related changes (e.g., in go.mod) could lead to an inconsistent and potentially broken state. See the specific comment for details.
|
|
||
| // Version of the Firebase Go Admin SDK. | ||
| const Version = "4.19.0" | ||
| const Version = "4.18.0" |
There was a problem hiding this comment.
Reverting the version number to 4.18.0 is correct for a rollback. However, this PR only modifies the version constant. Release commits, like the one being reverted, often include other changes such as dependency updates in go.mod, changelogs, or other documentation. If other files were changed in the original release PR, they should also be reverted here. An incomplete revert can leave the repository in an inconsistent state, potentially introducing subtle bugs or build issues.
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (#710) * fix(auth): Fixed auth error code parsing (#712) * fix(auth): Fixed auth error code parsing * fix(auth): Fixed test to use error message prefix * chore: update copyright headers from Google Inc. to Google LLC (#713) * chore: Update github actions workflows and integration test resources (#740) * chore: Pinned github actions to a full-length commit SHA * chore: Update integration test resources * chore: Added environment label to release action * Trigger integration tests * feat(firestore): Added Firestore Multi Database Support (#733) * feat(firestore): Add Firestore Multi Database Support * fix: Address gemini review * fix: gemini review * fix: Update name from API review * fix: Address review comments * chore: Fix CONTRIBUTING.md typo Co-authored-by: Lahiru Maramba <[email protected]> --------- Co-authored-by: Lahiru Maramba <[email protected]> * feat(auth): Add `QueryUsers` API (#727) This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options. RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination. * Update the release actions process (#741) This PR refactors the release automation to improve security by removing the direct merge from the workflow. * [chore] Release 4.19.0 (#742) * Revert "[chore] Release 4.19.0 (#742)" (#744) This reverts commit 3a86709. * chore: Update Release Workflows for Push triggers (#745) * chore: Update release actions to run on Release env * Trigger CI * update the actions * update the base_ref * remove fetch-depth to prevent conflicts * [chore] Release 4.19.0 Take 2 (#746) --------- Co-authored-by: Jonathan Edey <[email protected]> Co-authored-by: Lahiru Maramba <[email protected]>
2 participants
Reverts #742