-
Notifications
You must be signed in to change notification settings - Fork 272
chore: Update to Go 1.25 #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's Go language support to align with recent releases. It formally drops support for Go 1.23 and introduces support for Go 1.25, ensuring the project remains compatible with the latest stable Go versions. This change is reflected in both the project's documentation and its module definition, setting the minimum required Go version to 1.24. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project's supported Go versions, dropping 1.23 and adding 1.25. The changes in README.md correctly document this, and the go.mod file is updated to set the new minimum version to 1.24. My review includes a suggestion to use a more idiomatic version format in go.mod and to run go mod tidy to ensure module consistency after the version bump.
| module firebase.google.com/go/v4 | ||
|
|
||
| go 1.23.0 | ||
| go 1.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more idiomatic to specify the Go version using only the major and minor numbers (e.g., 1.24).
Additionally, after updating the Go version, it's important to run go mod tidy to ensure the go.mod and go.sum files are left in a consistent state. Please run the command and commit any resulting changes.
| go 1.24.0 | |
| go 1.24 |
Drop support for
1.23and add support for1.25Update dependencies