Fix AUTOLOAD resolution for imported forward-declared subroutines #128
+89
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where ExifTool commands (exiftool -list and -listw) failed with 'Undefined subroutine' errors when JPERL_LARGECODE=refactor was enabled. Problem: When Exporter imports a forward-declared subroutine (e.g., 'sub GetAllTags;'), the imported placeholder in the calling package wasn't configured to resolve via the exporting package's AUTOLOAD mechanism, breaking standard Perl semantics. Solution: 1. Exporter.exportToLevel: Handle empty caller() by defaulting to 'main' 2. Exporter.importFunction: Annotate imported forward-declaration placeholders with sourcePackage field pointing to the exporting package 3. RuntimeCode.apply (both overloads): Check sourcePackage first when attempting AUTOLOAD resolution for undefined subs This matches Perl's behavior where imported forward declarations resolve via the original package's AUTOLOAD. Test: - Added regression test: src/test/resources/unit/exiftool_exporter_autoload.t - Test passes in Perl, jperl (normal), and jperl (refactor mode) - All existing unit tests pass - ExifTool -list/-listw now get past the GetAllTags/GetWritableTags errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ExifTool commands (exiftool -list and -listw) failed with "Undefined subroutine" errors when JPERL_LARGECODE=refactor was enabled.
Root Cause
When Exporter imports a forward-declared subroutine, the imported placeholder wasn't configured to resolve via the exporting package's AUTOLOAD mechanism, breaking standard Perl semantics.
Solution
Made three key changes:
This matches Perl's behavior where imported forward declarations resolve via the original package's AUTOLOAD.
Testing
Files Changed