Adding support for IPoIB interfaces #297
Conversation
wmousa
force-pushed
the
ipoib_support
branch
from
8a65a3e to
2a4a165
Compare
wmousa
changed the title
network-scripts/ifup
Outdated
| net_log $"ERROR: could not add pkey ${PKEY_ID} as ${DEVICE} on dev ${PHYSDEV}" | ||
| exit 1 | ||
| } | ||
| fi |
There was a problem hiding this comment.
Also please set spacing of this and following line to 4 spaces. Thank you.
wmousa
force-pushed
the
ipoib_support
branch
from
2a4a165 to
54afbc4
Compare
The patch allow to ifup/ifdown IpoIB interfaces from network-scripts The required config is the following DEVICE=ib0.8005 # ib0 the it IB interface TYPE=Infiniband # the type is Infiniband PKEY=yes # indicator that it's IPoIB interface PKEY_ID=5 # the pkey number
wmousa
force-pushed
the
ipoib_support
branch
from
54afbc4 to
b4331f2
Compare
Done |
|
We were just discussing this with @jamacku on Friday and I have a feeling that this should not be here. At least on rhel7, there is a rdma package with contains ifup-ib and ifdown-ib scripts. So my guess is that you actually want to have this logic in https://github.com/Mellanox/rdma-utils |
|
Mellanox/rdma-utils is a repository that is used internally in Mellanox it has a bunch of other stuff that is not needed, nor is it maintained. ipoib configurations is standard and should not be in a vendor specific repo imo. |
There was a problem hiding this comment.
Pull Request Overview
Adds support for IPoIB (IP over InfiniBand) interfaces to network-scripts, enabling ifup/ifdown operations for InfiniBand network devices with partition keys (PKeys).
- Implements IPoIB interface creation and configuration logic in ifup script
- Adds dedicated ifdown-ib script for proper IPoIB interface teardown
- Integrates IPoIB support into main ifdown script routing logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| network-scripts/ifup | Adds IPoIB interface detection, kernel module loading, and device creation |
| network-scripts/ifdown-ib | New script for handling IPoIB interface deletion |
| network-scripts/ifdown | Routes IPoIB interfaces to the dedicated ifdown-ib script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| MATCH='^.+\.[0-9]{1,4}$' | ||
| if [[ "${DEVICE}" =~ $MATCH ]]; then | ||
| PHYSDEV=${DEVICE%.*} | ||
| fi |
There was a problem hiding this comment.
The PHYSDEV extraction logic has a flaw: if the DEVICE doesn't match the regex pattern, PHYSDEV remains unset, but it's still used later in line 165. This will cause the ip link add command to fail with an empty link parameter.
| fi | |
| fi | |
| if [ -z "${PHYSDEV}" ]; then | |
| net_log $"ERROR: Could not extract physical device from DEVICE='${DEVICE}'" | |
| exit 1 | |
| fi |
| check_device_down ${DEVICE} && { ip -o link set dev ${DEVICE} up; } | ||
| else | ||
| ip link add dev ${DEVICE} link ${PHYSDEV} type ipoib pkey ${PKEY_ID} || { | ||
| (/usr/bin/logger -p daemon.info -t ifup \$"ERROR: could not add |
There was a problem hiding this comment.
The dollar sign before the double quote should not be escaped with a backslash. It should be $\" instead of \$\" to properly expand the localized string.
| (/usr/bin/logger -p daemon.info -t ifup \$"ERROR: could not add | |
| (/usr/bin/logger -p daemon.info -t ifup $"ERROR: could not add |
| exit 1 | ||
| } | ||
| fi | ||
| exit 0 |
There was a problem hiding this comment.
This unconditional exit prevents the rest of the ifup script from executing. IPoIB interfaces still need IP configuration, DHCP setup, and other standard network interface initialization that occurs after this block.
| exit 0 |
4 participants
The patch allow to ifup/ifdown IPoIB interfaces from network-scripts
The required config is the following
DEVICE=ib0.8005 # ib0 the is IB interface
TYPE=Infiniband # the type is Infiniband
PKEY=yes # indicator that it's IPoIB interface
PKEY_ID=5 # the pkey number