fix(locale): remove empty string from Hebrew lorem words #3698
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
LGTM, perhaps we should add a test to check for empty strings in locale data? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3698 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2995 2995
Lines 236324 236323 -1
Branches 941 940 -1
=======================================
- Hits 236267 236266 -1
Misses 57 57
🚀 New features to boost your workflow:
|
xDivisionByZerox
added
c: bug
Member
I'm working on solving #3325. In there we can integrate this for sure 👍 |
xDivisionByZerox
approved these changes
Jan 20, 2026
Member
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Thanks for spotting that 🙌
Shinigami92
approved these changes
Jan 20, 2026
pkuczynski
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes an empty string entry from the Hebrew locale's lorem word list (
src/locales/he/lorem/word.ts).Problem
When calling
faker.lorem.words(n)with the Hebrew locale, occasionally one of the returned "words" is an empty string, resulting in unexpected output like" צש התידם"(leading space, only 2 visible words when 3 were requested).Solution
Remove the empty string at line 103 of the word list.
Related Issues
Fixes #3697