-
-
Notifications
You must be signed in to change notification settings - Fork 1k
refactor(locale): normalize phone_number data #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3518 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2880 2880
Lines 220503 220503
Branches 951 952 +1
==========================================
- Hits 220450 220448 -2
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inside data structures are not accounted for during the sorting. So we lose some comments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains some comments, which will be lost, as well.
Description
Follow-on to #2265.
Normalize the entries in the
phone_numbermodule definitions - in all locales. No entries have been removed. The changes are sorting only.How to verify
Checkout the branch:
The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:
You should end up with no changes in your work-tree.