Skip to content

fix(locale): weight common chinese surnames more frequently #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewmayer wants to merge 3 commits into
base: next
Choose a base branch
from
Open

fix(locale): weight common chinese surnames more frequently #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74f3ab8
fix(locale): weight common chinese surnames more frequently
matthewmayer Apr 6, 2025
54413dc
fix chars removed by accident
matthewmayer Apr 6, 2025
fb45c17
Merge branch 'next' into chinese-common-surnames
xDivisionByZerox Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions src/locales/zh_CN/person/last_name.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,26 @@
export default {
generic_common: [
Copy link
Member

@xDivisionByZerox xDivisionByZerox Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this extra key as it is not included in the module definitions type contract. I'd be in favor to allow (not enforce!) weighted lists in the name schemas in general. I could see this being introduced as a workaround at most for now.

'王',
'李',
'张',
'刘',
'陈',
'杨',
'黄',
'吴',
'赵',
'周',
'徐',
'孙',
'马',
'朱',
'胡',
'林',
'郭',
'何',
'高',
'罗',
],
generic: [
'丁',
'万',
Expand Down Expand Up @@ -69,7 +91,6 @@ export default {
'似',
'但',
'位',
'何',
'佘',
'余',
'佛',
Expand Down Expand Up @@ -129,7 +150,6 @@ export default {
'刀',
'刁',
'刑',
'刘',
'刚',
'初',
'利',
Expand Down Expand Up @@ -195,11 +215,9 @@ export default {
'后',
'向',
'吕',
'吴',
'吾',
'告',
'员',
'周',
'呼',
'和',
'咎',
Expand Down Expand Up @@ -256,7 +274,6 @@ export default {
'嬴',
'孔',
'字',
'孙',
'孛',
'孝',
'孟',
Expand Down Expand Up @@ -356,15 +373,13 @@ export default {
'开',
'弓',
'弘',
'张',
'弥',
'弭',
'强',
'归',
'彤',
'彭',
'律',
'徐',
'御',
'徭',
'德',
Expand Down Expand Up @@ -458,21 +473,17 @@ export default {
'朋',
'望',
'本',
'朱',
'朴',
'机',
'权',
'李',
'杜',
'杞',
'束',
'来',
'杨',
'杭',
'松',
'板',
'析',
'林',
'枚',
'果',
'枝',
Expand Down Expand Up @@ -589,7 +600,6 @@ export default {
'独',
'玄',
'玉',
'王',
'环',
'班',
'理',
Expand Down Expand Up @@ -706,7 +716,6 @@ export default {
'缑',
'缪',
'罕',
'罗',
'羊',
'羽',
'羿',
Expand All @@ -722,7 +731,6 @@ export default {
'肇',
'肖',
'肥',
'胡',
'胥',
'能',
'脱',
Expand Down Expand Up @@ -843,7 +851,6 @@ export default {
'赧',
'赫',
'赫连',
'赵',
'越',
'路',
'蹇',
Expand Down Expand Up @@ -894,7 +901,6 @@ export default {
'郜',
'郝',
'郦',
'郭',
'郯',
'郸',
'都',
Expand Down Expand Up @@ -946,7 +952,6 @@ export default {
'阿',
'陀',
'陆',
'陈',
'陶',
'隆',
'隋',
Expand Down Expand Up @@ -981,11 +986,9 @@ export default {
'饶',
'首',
'香',
'马',
'驹',
'骆',
'骑',
'高',
'魏',
'鱼',
'鲁',
Expand All @@ -995,7 +998,6 @@ export default {
'麦',
'麴',
'麻',
'黄',
'黎',
'齐',
'龙',
Expand Down
5 changes: 4 additions & 1 deletion src/locales/zh_CN/person/last_name_pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export default {
generic: [{ value: '{{person.last_name.generic}}', weight: 1 }],
generic: [
{ value: '{{person.last_name.generic_common}}', weight: 8 },
{ value: '{{person.last_name.generic}}', weight: 2 },
],
};