Planner: drop deprecated publishing keys #2 (BC) #26540
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@naltatis had no write access |
naltatis
reviewed
Jan 9, 2026
naltatis
reviewed
Jan 9, 2026
| Time time.Time `json:"time"` | ||
| Soc int `json:"soc"` | ||
| Time time.Time `json:"time"` | ||
| PlanStrategy api.PlanStrategy `json:"planStrategy"` |
Member
There was a problem hiding this comment.
PlanStrategy has effect for the static Plan and for RepeatingPlans. Therefore I wouldn't nest into the static plan and keep it directly in vehicleStruct.
Member
There was a problem hiding this comment.
I would like this as part of the plan- a strategy always relates to a (repeating) plan. But looking at https://github.com/evcc-io/evcc/pull/26540/changes#diff-65aed087489435cf1207d29104c2436829844af8ada75323d641e2b4bdc17058R19, we also need to do this for the repeating plan.
Co-authored-by: Michael Geers <michael@geers.tv>
naltatis
reviewed
Jan 9, 2026
iseeberg79
commented
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #24423, depends on #26291
based on #26293
TODO: