admin: support prometheus stats in protobuf format #43248
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step towards supporting prometheus native histograms as a histogram output format. Part of envoyproxy#32686 Signed-off-by: Greg Greenway <[email protected]>
ggreenway
commented
Jan 31, 2026
| Admin::RequestPtr makeRequest(AdminStream&); | ||
|
|
||
| private: | ||
| static Http::Code prometheusStats(absl::string_view path_and_query, Buffer::Instance& response, |
Member
Author
There was a problem hiding this comment.
This function hasn't existed in a long time; deleting the dangling declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards supporting prometheus native histograms as a histogram output format.
Part of #32686
Risk Level: Low; existing output is completely unchanged
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]