WindowClone: Fix has-pointer handling with reduced motion #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm usually more in favor of fixing causes rather than symptoms but in this case I'm also thinking if we should just have the close button visible all the time anyways? The style guidelines discourage using hover for actual functionality. Maybe @danirabbit has an opinion here? |
Member
|
@leolost2605 I think previously we left this as a hover effect since we have swipe-to-close on touch. But I think it would be fine to always show close buttons :) |
Member
|
@danirabbit yeah that was my first thought too but afaict we don't have swipe to close on touch? |
Member
|
@leolost2605 oh you're right because that's waiting on the touchscreen backend right? Either way, I'm +1 on showing close buttons all the time |
lenemter
added a commit
that referenced
this pull request
Nov 20, 2025
As suggested in #2641 (comment)
This was referenced Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason window clone's has-pointer is bugged with disabled animations :(