bin/editorconfig-el: Fix test failure with snapshot #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests don't like the "missing lexical-binding" warnings we get from Emacs-31. It's actually difficult to fix those warnings because the `lexical-binding` cookie has to be on the first line or on the second line but only if that second line starts with ";", and I don't know of a way to satisfy those constraints are still have a runnable shell script. There are various possible workarounds, such as cutting the first few lines before we pass the content of `$0` to Emacs, but it seemed simpler to just stamp out the function that emits the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests don't like the "missing lexical-binding" warnings we get from Emacs-31. It's actually difficult to fix those warnings because the
lexical-bindingcookie has to be on the first line or on the second line but only if that second line starts with ";", and I don't know of a way to satisfy those constraints are still have a runnable shell script.There are various possible workarounds, such as cutting the first few lines before we pass the content of
$0to Emacs, but it seemed simpler to just stamp out the function that emits the warning.