Remove ad-hoc tab_width / indent_size handling from editorconfig-core #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Test failed: |
monnier
force-pushed
the
core-size-agnostic
branch
3 times, most recently
from
000182c to
a9bf87a
Compare
* editorconfig-core.el (editorconfig-core-get-properties-hash): Remove code that sets tab_width from indent_size and vice-versa, since that's better done (and is done) later in `editorconfig.el`. Also remove autoload cookie since this file is already `require`d from the caller anyway. Remove`confversion` arg, not used. (editorconfig-core-get-properties): Move to `editorconfig-el`. * bin/editorconfig-el (editorconfig-core-get-properties): New function taken from `editorconfig-core.el`.
monnier
force-pushed
the
core-size-agnostic
branch
from
a9bf87a to
b291561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from
editorconfig-core.elcode that sets tab_width from indent_size and vice-versa, since that's better done (and is done) later ineditorconfig.el.