Extract cluttered autoscaling mode handling into dedicated classes #2975
+208
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
formalize-autoscale
branch
3 times, most recently
from
19052cc to
0ad9f13
Compare
Contributor
Test Results 176 files 176 suites 26m 53s ⏱️ Results for commit e9dc9dd. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
formalize-autoscale
branch
5 times, most recently
from
9e7415d to
4ebdd85
Compare
The handling of different autoscaling modes is currently spread across the DPIUtil class, based on String matching and system property retrieval. This change extracts and AutoScale class that encapsulates functionality and information related to a specific autoscaling mode (string representation, conversion, compatibility to monitor-specific scaling) into a dedicated class. This is particularly a preparation for changing the default mode on Windows to quarter/monitor-specific scaling, as adapting the String matching logic for that would become incomprehensive.
HeikoKlare
force-pushed
the
formalize-autoscale
branch
from
4ebdd85 to
e9dc9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of different autoscaling modes is currently spread across the DPIUtil class, based on String matching and system property retrieval.
This change extracts and AutoScale class that encapsulates functionality and information related to a specific autoscaling mode (string representation, conversion, compatibility to monitor-specific scaling) into a dedicated class.
This is particularly a preparation for changing the default mode on Windows to quarter/monitor-specific scaling, as adapting the String matching logic for that would become incomprehensive.