-
Notifications
You must be signed in to change notification settings - Fork 191
[Win32] Enable monitor-specific scaling by default #2955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Win32] Enable monitor-specific scaling by default #2955
Conversation
Test Results 113 files - 31 113 suites - 31 7m 15s ⏱️ - 8m 23s Results for commit e359a33. ± Comparison against base commit 7934e5a. This pull request removes 43 tests.This pull request skips 8 and un-skips 1 tests.♻️ This comment has been updated with latest results. |
|
I'll be happy with a new default because the installer won't need a -D option then. I was testing that the other day and it's much nicer with the new behavior. |
91adb29 to
1c9ab79
Compare
|
Of course +1, defaults should be using the best functionality and it's unlikely that a user "only wants his menu (done automatically by the os)" scaled. |
By now, SWT had monitor-specific scaling on Windows disabled by default and used the existing, single-zoom HiDPI support. There are good reasons to now change the default of SWT to have monitor-specific scaling enabled: - Eclipse applications default to have monitor-specific scaling enabled for several months now, so SWT and Eclipse default behaviors are different - With default JVM settings, pure SWT application have no proper scaling as the existing HiDPI support requires DPI awareness "System" to function properly whereas the JVM default is "PerMonitorV2" and requires the application to scale on its own. So by default, SWT applications currently have no scaling at all - The feature has matured throughout the last year with it being the default for Eclipse application for several months now. This change adapts the SWT default to enable monitor-specific scaling on Windows.
1c9ab79 to
e359a33
Compare
By now, SWT had monitor-specific scaling on Windows disabled by default and used the existing, single-zoom HiDPI support. There are good reasons to now change the default of SWT to have monitor-specific scaling enabled:
This change adapts the SWT default to enable monitor-specific scaling on Windows.
How to test
Just run any SWT snippet and move it between monitors of different zooms. It will adapt it's scale while it did not do prior to this PR.
Feedback welcome
I would appreciate feedback on whether we agree on changing this default. I propose to merge this before M2 so that people get aware it early enough. When merging, I will also create an according N&N.