Skip to content

update aws credentitas build #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
redwarn wants to merge 2 commits into from
Closed

update aws credentitas build #658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c4755
update aws credentitas build
redwarn Oct 22, 2025
e64b9dc
Update s3.go
redwarn Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@
func (s *S3Storage) IsRangeSupported() bool { return true }

func getAwsConfig(ctx context.Context, accessKey, secretKey string) (aws.Config, error) {
if accessKey == "" || secretKey == "" {
return config.LoadDefaultConfig(ctx, config.WithRegion(region))

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Linting 

undefined: region) (typecheck)

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Linting 

undefined: region) (typecheck)

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Linting 

undefined: region (typecheck)

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Test with 1.24 

undefined: region

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Test with 1.22 

undefined: region

Check failure on line 183 in server/storage/s3.go

View workflow job for this annotation

GitHub Actions / Test with 1.23 

undefined: region
Copy link
Collaborator

@paolafrancesca paolafrancesca Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

region is undefined.

}
return config.LoadDefaultConfig(ctx,
config.WithCredentialsProvider(credentials.StaticCredentialsProvider{
Value: aws.Credentials{
Expand Down
Loading