added s3-ec2role provider; fix #431 #433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| options = append(options, server.UseStorage(storage)) | ||
| } | ||
| case "s3-ec2role": // using AWS IAM Role and EC2 Profile |
Collaborator
There was a problem hiding this comment.
this is not really needed.
you should rather add something like s3-credentials-type config param, default to access-key and refactor
Line 176 in e97fdcb
paolafrancesca
requested changes
Nov 8, 2021
Collaborator
paolafrancesca
left a comment
paolafrancesca
left a comment
There was a problem hiding this comment.
see my comment, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.