Update IndexPage.csp Fixed indentation and remove excessive lines. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed indentation and remove excessive lines.
marty1885
requested changes
Aug 14, 2023
Member
marty1885
left a comment
marty1885
left a comment
There was a problem hiding this comment.
Hi @albaropereyra22 Thanks for fixing our code style issues. I should have put more effort into them. Dang.
However, there's a thing I need you to change before I can merge it.
Comment on lines
105
to
+112
| <pre><code class="c++">using Callback = std::function<void (const HttpResponsePtr &)> ; | ||
|
|
||
| app().registerHandler("/", [](const HttpRequestPtr& req, Callback &&callback) | ||
| { | ||
| app().registerHandler("/", [](const HttpRequestPtr& req, Callback &&callback) | ||
| { | ||
| auto resp = HttpResponse::newHttpResponse(); | ||
| resp->setBody("Hello World"); | ||
| callback(resp); | ||
| });</code></pre> | ||
| });</code></pre> |
Member
There was a problem hiding this comment.
@albaropereyra22 This lack of space is intended. These are C++ shown within a <pre> block. Which does not perform space collapsing. When added, theses indents will also show up in the web page.
Please revert the changes within pre blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed indentation and remove excessive lines.